[Koha-bugs] [Bug 5347] late order management

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

--- Comment #40 from Jonathan Druart <jonathan.druart at biblibre.com> 2011-12-30 09:13:43 UTC ---
(In reply to comment #39)
I can't apply your patch. Have you created it after applying 2 others patchs ?

I got :
fatal: sha1 information is lacking or useless (C4/Letters.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

You're right about translation of "no email" error.
We can replace in SendAlerts l.402
die "This bookseller has no email\n";
with 
return { error => "no_email" };

and in acqui/lateorders.pl
replacing
    eval {
        SendAlerts( 'claimacquisition', \@ordernums,
$input->param("letter_code") );
        AddClaim ( $_ ) for @ordernums;
    };
    if ( $@ ) {
        $template->param(error_claim => $@);
    } else {
        $template->param(info_claim => "Emails have been sent");
    }
with something like :
    eval {
        my $err = SendAlerts( 'claimacquisition', \@ordernums,
$input->param("letter_code") );
        AddClaim ( $_ ) for @ordernums;
    };
    if ( $@ ) {
        $template->param(error_claim => $@);
    } elsif ( defined $err{error} ) {
        $template->{VARS}->{'error_claim'} = 'no_email';
    } else {
        $template->{VARS}->{'info_claim'} = 1;
    }

I could propose a patch but without applying your patch, it's not useful :-/

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.