[Koha-bugs] [Bug 6836] jQuery plugin Datatables integration

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836

--- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> 2011-12-30 10:49:10 UTC ---
(In reply to comment #30)

> > There are 2 minor perlcritic errors:
> > perlcritic C4/Utils/DataTables.pm
> > Code before strictures are enabled at line 25, column 1.  See page 429 of PBP. 
> > (Severity: 5)
> > Variable declared in conditional statement at line 111, column 5.  Declare
> > variables outside of the condition.  (Severity: 5)
> > 
> Just FYI severity 5 is the most severe. Those are pretty severe style
> violations.
Agreed. By "minor" I wanted to say "easy to fix".
The 1st is fixed by a use strict at the beginning
the 2nd one is also easy to fix by removing the declaration from the condition!

but they must be fixed to have the patch pushed

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.