[Koha-bugs] [Bug 1633] Add ability to take book cover images from local img db

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633

--- Comment #36 from Jared Camins-Esakov <jcamins at cpbibliography.com> 2011-12-30 13:56:16 UTC ---
Magnus,

Thanks for testing. I have five revised patches coming up that fix your
blockers, and a few of your enhancements. Hot off the keyboard!

(In reply to comment #35)
> * No image shown when there is just one
> 
> LocalCoverImages = On
> 
> Uploaded one image and attached it to biblionumber = 1. 
> 
> Image shows OK here: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1
> But: "There are no images for this record." at
> /cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=1&imagenumber=1
> 
> Changing line 68 of
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt from this:
>   [% IF ( images.size > 1 ) %]
> to this: 
>   [% IF ( images.size > 0 ) %]
> makes the image display. 
> 
> Uploading a second image makes both of them display correctly. 

Fixed

> * AllowMultipleCovers does not stop multiple covers
> 
> With AllowMultipleCovers = "Don't", /cgi-bin/koha/tools/upload-cover-image.pl
> was automatically set to "Replace existing covers", but I had no problem adding
> multiple covers to one record. 

Fixed

> * Always "Click on an image..."
> 
> On records that have no associated images I always see this: "Click on an image
> to view it in the image viewer", not this: "No images have been uploaded for
> this bibliographic record yet. Please upload one.". 
> 
> Changing line 522 in
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt from 
>   [% IF ( localimages ) %]
> to 
>   [% IF ( localimages.0 ) %]
> seems to solve this. 
> 
> I'm not sure, but I think that when there are no images, localimages is an
> array where the first element is undef, not an array that is undefined - or
> something like that...

Fixed

> *** Enhancements
> 
> * How can images be deleted? 

Good point. It is not yet possible. I will put that on my to-do list.

> * Thumbnails have empty alt
> 
> Thumbnails displayed on the right hand side in the image viewer (both OPAC and
> Intranet) have empty alt attributes: 
> 
> <img alt=""
> src="/cgi-bin/koha/catalogue/image.pl?imagenumber=3&amp;thumbnail=1" id="3"
> class="thumbnail">
> 
> It could perhaps say alt="Thumbnail" or something similar? 

Done!

> * Still possible to see images when OPACLocalCoverImages is off
> 
> OPACLocalCoverImages = Don't display
> 
> I can still see the image at /cgi-bin/koha/opac-image.pl?imagenumber=1

Not anymore. ;)

> * Wrong POD in tools/upload-cover-image.pl?
> 
> The POD on line 33 of tools/upload-cover-image.pl says: "Files greater than
> 100K will be refused. Images should be 140x200 pixels. If they are larger they
> will be auto-resized to comply." 
> 
> I was able to upload an image of 1.3MB without any trouble, and it was resized
> correctly. 
> 
> The last part of this has perhaps not been updated to take into account the
> 600x800 pixel max size of the "large" view? 

There was incorrect POD, but I changed it.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.