[Koha-bugs] [Bug 5681] Autobarcode using C4::Barcode has issues with leading zeros and large values

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |PATCH-Sent
       Patch Status|---                         |Needs Signoff

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> 2011-02-02 03:40:00 UTC ---
I have tested this patch, 

Before patch
ok 32 - (incremental ) Barcode Creation : new(incremental)
ok 33 - (incremental ) autoBarcode()    : incremental
ok 34 - (incremental ) initial()        : 0000001
# .    (incremental ) db_max()         : 0000001
ok 35 - (incremental ) max()            : 2
ok 36 - (incremental ) value()          : 2

After patch

ok 32 - (incremental ) Barcode Creation : new(incremental)
ok 33 - (incremental ) autoBarcode()    : incremental
ok 34 - (incremental ) initial()        : 0000001
# .    (incremental ) db_max()         : 0000001
ok 35 - (incremental ) max()            : 0000002
ok 36 - (incremental ) value()          : 0000002

I also checked the annual ones

Before
ok 2 - (annual      ) Barcode Creation : new(annual)
ok 3 - (annual      ) autoBarcode()    : annual
ok 4 - (annual      ) initial()        : 2011-0001
# .    (annual      ) db_max()         : 2011-18918291
ok 5 - (annual      ) max()            : 2011-18918292
ok 6 - (annual      ) value()          : 2011-18918292

after

ok 2 - (annual      ) Barcode Creation : new(annual)
ok 3 - (annual      ) autoBarcode()    : annual
ok 4 - (annual      ) initial()        : 2011-0001
# .    (annual      ) db_max()         : 2011-18918291
ok 5 - (annual      ) max()            : 2011-18918292
ok 6 - (annual      ) value()          : 2011-18918292

So patch does what it says it does, and does fix the stripping of leading zeros

Will sign off

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.