[Koha-bugs] [Bug 4339] catalog reports doesn't count a lot of items

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4339

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |paul.poulain at biblibre.com
         Resolution|                            |FIXED

--- Comment #3 from Paul Poulain <paul.poulain at biblibre.com> 2011-02-22 12:51:20 UTC ---
Owen, the interesting lines are :
-    $strsth .= "select distinctrow $linefield from biblioitems left join items
on (items.biblioitemnumber = biblioitems.biblioitemnumber) where barcode $not
LIKE ? AND $line is not null ";
+    my $strsth = "SELECT DISTINCTROW $linefield FROM biblioitems 
+                    INNER JOIN items USING (biblioitemnumber)
+                  WHERE $line IS NOT NULL ";

see the distinction between INNER JOIN and LEFT JOIN :
http://www.w3schools.com/sql/sql_join_left.asp and
http://www.w3schools.com/sql/sql_join_inner.asp

(the rest of the patch is just changing lc to UC for SQL terms)

it's in master though, so marking it resolved

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.