[Koha-bugs] [Bug 5569] New: addbiblio fails while editing and deleting mandatory repeatable subfields

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5569

           Summary: addbiblio fails while editing and deleting mandatory
                    repeatable subfields
 Change sponsored?: ---
           Product: Koha
           Version: rel_3_2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: Cataloging
        AssignedTo: gmcharlt at gmail.com
        ReportedBy: januszop at gmail.com
         QAContact: koha-bugs at lists.koha-community.org
                CC: ian.walls at bywatersolutions.com
   Estimated Hours: 0.0


Created attachment 2936
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2936
Proposed patch

If a subfield has both attributes: mandatory and repeatable a following problem
occurs.  If the record is edited and there was more then one such subfield it
should be still possible to delete (UnClone) or one leave empty all but one
occurrence of such a subfield.  But it is not.

There are two cases: 

1) If one tries to UnClone the subfield, virtually nothing happens (because
AreMandatoriesNotOk tries then to check
!document.getElementById(mandatories[i]).value, whereas this object does not
exist at the time, so the script fails giving no information.

2) If one deletes the text area and leaves it empty (having still another
subfield correct), then the alert "Can't save this record because the following
..." appears.

Both is wrong.

Attached is proposed patch.

Regards,

Janusz

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.