[Koha-bugs] [Bug 5026] Undefined dates not formatted in serials update

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5026

--- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2011-01-13 11:21:33 UTC ---
Thanks for updating the patch. Testing these changes seemed fine, but it is
hard to say if you cover all changes. Did some code checking too on these
changes and have four questions.

Serials.pm
1) Line 734 $line->{planneddate} should be $line->{$datefield} ?

serials-edit.pl
2) Line 99 If you assign to @serialsid in the for loop, you only keep the last
results. There was a push to this array in the old code. Looks like a bug? 

3) Line 119 This was already, but why is debug 1 ?

4) Line 376 A former comment stated that the sort was needed. Sure that you
could remove it?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.