[Koha-bugs] [Bug 5661] New: Authority search return an "Error 500" when "Sort by" is set to "No order"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5661

           Summary: Authority search return an "Error 500" when "Sort by"
                    is set to "No order"
 Change sponsored?: ---
           Product: Koha
           Version: rel_3_2
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Searching
        AssignedTo: gmcharlt at gmail.com
        ReportedBy: fcapovilla at live.ca
         QAContact: koha-bugs at lists.koha-community.org
   Estimated Hours: 0.0


Created attachment 3026
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3026
Proposed patch

This error can be reproduced in two places :

In authorities/authorities-home.pl :
Do any authority search using "None" as a sort order. Error 500 is returned.

In authorities/auth_finder.pl :
( When adding or modifying a MARC record, click on the "..." next to the 100$a
field to do an authority search and get to this page. )
Do any authority search using "No order" for the "Sort by" field. Error 500 is
returned.


This happens because on line 267 of AuthoritiesMarc.pm, a "@or" is added to the
query even when $orderstring is empty, which invalidates the query.

Patch attached to fix the problem.


Note : 
Because there was another bug affecting the way search queries are constructed
( Bug 4309 ) Error 500s might be caused by the number of search terms AND by
this bug.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.