[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #2 from Frédéric Demians <frederic at tamil.fr> 2011-07-15 17:43:42 UTC ---
I don't agree with this patch.

1) It doesn't handle multiple ISBN. In UNIMARC biblio record, you can
   repeat 010 field. With this patch, the first ISBN is 'normalized'.
   The followings are kept as they are.

2) This line doesn't sound good:

   $operand =~ s/-//g if (C4::Context->preference("IsbnIssnRemoveHyphens"));

   '-' doesn't have the same meaning depending of the context. It must
   be interpreted differently in a term and in a ISBN. In an ISBN, it
   must be suppressed to concatenate all ISBN parts. In a phrase, it is
   a breaking character like space, comma, etc. 

3) With this patch, ISBN stored in Koha DB don't follow anymore
   MARC21/UNIMARC format which specify that hyphens must be present.

In my opinion, correct ISBN indexing and search should be delegated to
Zebra and mustn't modify stored biblio records. We could create a new
index type (we already have word, phrase, numeric index types). For this
type, hyphens could be suppressed by Zebra. And Koha search query
parser could identify ISBN/ISSN by a regex and suppress hyphens only for
them before sending search query to Zebra.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.