[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jul 15 19:45:58 CEST 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no

--- Comment #3 from Magnus Enger <magnus at enger.priv.no> 2011-07-15 17:45:58 UTC ---
Thanks for remembering NORMARC! ;-) 

ISBNs and ISSNs are treated the same way in NORMARC and MARC21, so this: 

   } elsif ($encoding eq 'MARC21') {
   ...
   } elsif ($encoding eq 'NORMARC') {

could just as well be turned into this: 

   } elsif ($encoding eq 'MARC21' || $encoding eq 'NORMARC') {

to avoid some redundant code. Other places in the code treat MARC21 as the
default, so this could be simplified even further, to this: 

   } else {

Just a suggestion!

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


More information about the Koha-bugs mailing list