[Koha-bugs] [Bug 6598] New: OPACFineNoRenewals syspreference does not stop user renewing in opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6598

             Bug #: 6598
           Summary: OPACFineNoRenewals syspreference does not stop user
                    renewing in opac
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: OPAC
        AssignedTo: oleonard at myacpl.org
        ReportedBy: colin.campbell at ptfs-europe.com
         QAContact: koha-bugs at lists.koha-community.org


This option is intended to stop users with fines from using opac to renew their
books. Because the global variable patron_flagged is mistakenly taken to be a
variable within larger structures in a couple of places the restriction is
never applied. The opac display is also affected (a bogus table column is added
and an empty message box is displayed)

Fixing the above logic reveals two further bugs to address:
The Renew Selected button is displayed even although you cannot select any for
renewal.

The option cannot be turned off. When editing the syspref it says 'leave blank
to disable' as that is read in the script as the value 0.00 it disables
renewing for all borrowers with fines. It needs to be set to high value to
allow (relatively) unrestricted opac renewals

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.