[Koha-bugs] [Bug 6460] New: No log generated if Action set to All or Modify or Delete

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6460

             Bug #: 6460
           Summary: No log generated if Action set to All or Modify or
                    Delete
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Transaction logs
        AssignedTo: paul.poulain at biblibre.com
        ReportedBy: januszop at gmail.com
         QAContact: koha-bugs at lists.koha-community.org


In "Browse system logs" dialogue, if Action is set to All or Modify or Delete,
no logs are generated, despite of other settings.  

This is due to modifications introduced to sub C4::GetLogs and to
tools::viewlog by the patch to Bug 6014.

1) Actions are logged as MODIFY, DELETE etc., whereas template viewlog.t* uses
mod, del and passes it to viewlog.pl.  That is why, consequently, wildcards (%)
was used in GetLogs for action (prior to patch 6014).  This has to be restored.

2) Also, @action is, after changes made by 6014, a one element list, even if
the first and only element is an empty string ("") for All (actions).  That is
why, in GetLogs, one has to check if the first element of the list is not ""
instead of checking the length of the list (which is always 1). 

A patch will follow.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.