[Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |januszop at gmail.com
         Resolution|FIXED                       |

--- Comment #7 from Janusz Kaczmarek <januszop at gmail.com> 2011-06-05 17:59:01 UTC ---
This patch, beside that it adds some enhancements, introduces also problems
with UNIMARC authorities, if summary is defined for UNIMARC authorities
according to the standard settings from installation files (e.g.
autorites_norme_unimarc.sql) 

Try this (having authorities summaries defined in the standard form, cf.
autorites_norme_unimarc.sql or screenshot and subsequent subfields in authority
records defined as well):

1. Go: Cataloguing --> New Record
2. Go to a field controlled by authority, of which you know that has has "--"
in summary and subfields preceded by "--" defined, e.g. SNC in standard UNICODE
situation with x, y or z subfields
3. Click on ...
4. Search for such a term which has x, y or z defined (and a of course)
5. Try to click on 2 next to search result

You should get en error (cf. screenshot).

This is because of the following:  

In the patch 4838 a notion of "repet" is introduced.  In line 77 of
auth_finder.pl "--" is used to extract (in fact: guess) the subsequent repets
from summary (produced by C4::BuildSummary).  BUT if there is only one heading
field in the authority record and by chance this field contains subfields,
which--according to the summary template--will be separated by two dashes, then
"repets" will be created (whereas should not) and by clicking on 2 you get in
troubles in blinddetail-biblio-search.pl, when executing:

    my $field = $fields[$repet];
    for ( $field->subfields ) {

In described scenario, $field is not defined (@fields has only one element),
hence you get error.

What can be done?  My ideas about it:  Either one should modify the patch in a
way that it will guess "repets" correctly OR change the default summary
templates in autorites_norme_unimarc.sql AND (warn people using UNIMARC to
modify their existing summaries templates OR make the modification for them in
updatedatabase.pl).

BTW changing the template to something like "[250a][ - 250x][ - 250y][ - 250z]
[(250b)]" (one dash instead of two) helps, of course.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.