[Koha-bugs] [Bug 6048] printoverdues.sh bash odities

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 8 17:32:28 CEST 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6048

--- Comment #3 from Joe Atzberger <ohiocore at gmail.com> 2011-06-08 15:32:28 UTC ---
$ misc/cronjobs/printoverdues.sh ~/Downloads/
/usr/lib/pymodules/python2.6/pyPdf/pdf.py:52: DeprecationWarning: the sets
module is deprecated
  from sets import ImmutableSet
Converting /home/atz/Downloads//2_factor.html to
/home/atz/Downloads/2_factor.pdf...
tar: Cowardly refusing to create an empty archive
Try `tar --help' or `tar --usage' for more information.

Looks like problems with the tar targetting.

$directory is never set to anything (should be $1).

This script needs a lot more error checking.  For example, we shouldn't be
tarring or printing ANYTHING if xhtml2pdf has failed or returned error.  This
is pretty likely to happen since the script requires an entirely new language
dependency and a large package in that language.

Command line options are also illogically dependent.  We shouldn't have to
specify a CSS file in order to target print lp3.  

However, the actual patch is OK, it's just the script as a whole needs work. 
Let me know if you want me to proceed with broader fixes.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


More information about the Koha-bugs mailing list