[Koha-bugs] [Bug 6503] New: Variable $sth is declared 3 times (with keyword "my") in "makepayment" sub of "Accounts.pm"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6503

             Bug #: 6503
           Summary: Variable $sth is declared 3 times (with keyword "my")
                    in "makepayment" sub of "Accounts.pm"
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Patrons
        AssignedTo: kyle.m.hall at gmail.com
        ReportedBy: ricmarques at spamcop.net
         QAContact: koha-bugs at lists.koha-community.org
                CC: gmcharlt at gmail.com


In the code available today (14-Jun-2011), in Koha git's "master" branch, the
file "Accounts.pm" (in the "C4" directory) has the variable "$sth" declared 3
times in the "makepayment" sub. 

This causes the following warnings to appear when running "make test" in Koha
installation, for several tests:

t/Heading.t ......................... "my" variable $sth masks earlier
declaration in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line
172.
"my" variable $sth masks earlier declaration in same scope at
kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 188.
[...]
t/ILSDI_Services.t .................. "my" variable $sth masks earlier
declaration in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line
172.
"my" variable $sth masks earlier declaration in same scope at
kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 188.

[...etc...]


Therefore, I'm removing the "my" keyword from the declarations of "$sth" in
lines 172 and 188 of "Accounts.pm".

Patch will follow shortly.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.