[Koha-bugs] [Bug 6503] Variable $sth is declared 3 times (with keyword "my") in "makepayment" sub of "Accounts.pm"

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 15 00:44:28 CEST 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6503

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> 2011-06-14 22:44:28 UTC ---
Created attachment 4467
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4467
Bug 6503 - Variable $sth is declared 3 times (with keyword "my") in
"makepayment" sub of "Accounts.pm"

In the code available today (14-Jun-2011), in Koha git's "master" branch,
the file "Accounts.pm" (in the "C4" directory) has the variable "$sth"
declared 3 times in the "makepayment" sub. This causes the following
warnings to appear when running "make test" in Koha installation, for
several tests:
t/Heading.t ......................... "my" variable $sth masks earlier
declaration
in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 172.
"my" variable $sth masks earlier declaration in same scope at
kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 188.
[...]
t/ILSDI_Services.t .................. "my" variable $sth masks earlier
declaration
in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 172.
"my" variable $sth masks earlier declaration in same scope
at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 188.
[...etc...]

Therefore, I'm removing the "my" keyword from the declarations of "$sth"
in lines 172 and 188 of "Accounts.pm".

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


More information about the Koha-bugs mailing list