[Koha-bugs] [Bug 5878] overdue printing fixes and improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5878

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> 2011-03-19 17:27:15 UTC ---
Tried testing this, here are my notes:

1) The default settings for items.content do not make much sense to me:

-my $itemscontent = join( ',', qw( date_due title barcode author itemnumber )
);
+my $itemscontent = join( ',', qw( issuedate title barcode author biblionumber
date_due) );

itemnumber is better than biblionumber, although both are only confusing for
patrons. date_due makes sense. I would perhaps suggest:

my $itemscontent = join( ',', qw( date_due title author callnumber barcode) )

2) Running overdue_notices.pl creates a lot of output on command line:

no query in themelanguage at /home/katrin/kohaclone/C4/Output.pm line 152.
---
altcity: Alternative City
altnotes: Alternative Contact Notes
altphone: Alternative Phone
altrelationship: Relationship of Alternative Contact
altstreetaddress: ' Alternative Street Address'
altsuburb: Alternative Suburb
area: Area
author: Author
barcode: Barcode
biblio.author: Author
biblio.datecreated: Creation Date
biblio.frameworkcode: Framework Code
biblio.timestamp: Modification Date
[...]

3) Using -html to create print notices with <item> syntax in overdue template
creates a lot of error messages (additional to output above)

ODUE:
<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>,
Barcode: <<items.barcode>> Fine: <fine>EUR</fine></item>

Error messages from overdue_notices.pl with patch applied:
Use of uninitialized value in join or string at ./overdue_notices.pl line 502.
Use of uninitialized value in join or string at ./overdue_notices.pl line 502.
issuedatetitlebarcodeauthorbiblionumberdate_due at ./overdue_notices.pl line
503.
Use of uninitialized value in concatenation (.) or string at
./overdue_notices.pl line 504.
Use of uninitialized value in concatenation (.) or string at
./overdue_notices.pl line 504.
;Title;Barcode;Author;Biblio Number (koha internal);; at ./overdue_notices.pl
line 504.
Use of uninitialized value $fine in string at ./overdue_notices.pl line 706.
Use of uninitialized value $fine in string at ./overdue_notices.pl line 706.

Error messages from master branch in comparison:
Use of uninitialized value $fine in string at ./overdue_notices.pl line 671.
Use of uninitialized value $fine in string at ./overdue_notices.pl line 671.
Wide character in print at ./overdue_notices.pl line 579.

4) -html with items.content in overdue notice template:

With patch applied:
[...]
Use of uninitialized value in join or string at ./overdue_notices.pl line 502.
Use of uninitialized value in join or string at ./overdue_notices.pl line 502.
issuedatetitlebarcodeauthorbiblionumberdate_due at ./overdue_notices.pl line
503.
Use of uninitialized value in concatenation (.) or string at
./overdue_notices.pl line 504.
Use of uninitialized value in concatenation (.) or string at
./overdue_notices.pl line 504.
;Title;Barcode;Author;Biblio Number (koha internal);; at ./overdue_notices.pl
line 504.

On master: no output from overdue_notices.pl

5) In the created html file the headings for columns issue_date and date_due
are missing. 

In general the created files and mails looked ok, but lot of error messages and
additional created from running overdue_notices.pl.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.