[Koha-bugs] [Bug 5683] link_bibs_to_authorities.pl can corrupt records

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5683

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Needs Signoff               |Signed Off

--- Comment #15 from Chris Cormack <chris at bigballofwax.co.nz> 2011-05-13 02:08:24 UTC ---
Applied the patch containing the updated tests, ran the test

rorohiko:[git/5683-]:~/git/koha% perl t/db_dependent/Biblio.t
1..9
ok 1 - use C4::Biblio;
DBD::mysql::db do failed: Unknown or incorrect time zone: 'Pacific/Auckland' at
C4/Context.pm line 700, <DATA> line 496.
ok 2 - Makes sure title field in biblio is empty.
ok 3 - uses ModBiblio to add a title to the previously created record and
checks that its there.
ok 4 - Makes sure the isbn is still there after using ModBiblio.
ok 5 - First test of GetBiblioItemData to get same result of previous two
GetBiblioData tests.
ok 6 - Second test checking it returns the correct isbn.
ok 7 - ModBiblio handles authority-linked 655
ok 8 - ModBiblio handles 655 with authority link but no heading
# Field 655 must have indicators (use ' ' for empty indicators) at
C4/Charset.pm line 141
not ok 9 - ModBiblio handles 655 with no subfields
#   Failed test 'ModBiblio handles 655 with no subfields'
#   at t/db_dependent/Biblio.t line 70.
# Looks like you failed 1 test of 9.

Applied the patch to fix it
rorohiko:[git/5683-]:~/git/koha% perl t/db_dependent/Biblio.t
1..9                                                         
ok 1 - use C4::Biblio;
DBD::mysql::db do failed: Unknown or incorrect time zone: 'Pacific/Auckland' at
C4/Context.pm line 700, <DATA> line 496.
ok 2 - Makes sure title field in biblio is empty.
ok 3 - uses ModBiblio to add a title to the previously created record and
checks that its there.
ok 4 - Makes sure the isbn is still there after using ModBiblio.
ok 5 - First test of GetBiblioItemData to get same result of previous two
GetBiblioData tests.
ok 6 - Second test checking it returns the correct isbn.
ok 7 - ModBiblio handles authority-linked 655
ok 8 - ModBiblio handles 655 with authority link but no heading
ok 9 - ModBiblio handles 655 with no subfield

Patch fixes the issue, signing off

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.