[Koha-bugs] [Bug 6328] Fine in days does not work

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328

--- Comment #24 from Paul Poulain <paul.poulain at biblibre.com> 2011-05-27 09:46:46 UTC ---
(In reply to comment #23)
> After Katrin comments I finally could appropriately test this patch. Sorry to
> keep bothering you after all the sign-offs, but I'm not sure if this is the
> desired behaviour.
it's fine you keep bothering = the more eyes, the more bugs can be found !

> A. You can checkout new items to a patron who is already late if you haven't
> checked in the item that will cause debarrement. You only get a yellow message,
> but it's still possible to lend items to patron.
I think it's a correct behaviour. If you want to debarr the user immediatly
when he is one day late, then you can/must use
/cgi-bin/koha/tools/overduerules.pl, and run overdue_notices.pl every night
(after midnight)


> B. koha is watching for debarrement in more than one place: borrowers.debarred
> and in old_issues. Making an on-the-fly calculation upon check out for the
> debarred time left based on old_issues.date_due and old_issues.returndate, and
> not looking into borrowers.debarred, which I think is the purposo of these
> patches.
> 
> Steps to reproduce:
> 1. same as A
> 2. same as A
> 3. same as A
> 4. check in the item that will produce debarrement
> 5. patron gets debarred and a date is set in borrowers.debarred
> 6. lift debarrement and check DB:
> 
> select debarred from borrowers where borrowernumber = <subject_patron_number>;
> 
> In my test:
> 
> select debarred from borrowers where borrowernumber = 5;
> +----------+
> | debarred |
> +----------+
> | NULL     |
> +----------+
> 
> So my patron is really NOT debarred now.
> 
> 7. try to loan an item and you'll get this message:
> 
> Patron has had overdue items and is blocked for 3 day(s).
> 
Well spotted ! It seems the behaviour is different on biblibre/master,
investigating, there are some code diffs as well. Maybe a patch that has not
been reported.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.