[Koha-bugs] [Bug 6554] Broken encoding in members home/search page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #28 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2011-11-02 13:49:23 UTC ---
Just some "fast" preliminary QA remarks from glimsing through the patches.

I agree that encoding data in Template.pm is actually not correct and that
specifying utf8 on std output with binmode or use open is a better practice
than what is done in current Koha. Check showmarc.p/opac-showmarc.pl where I
recently decoded output from template to prevent double encoding. This is a
place that therefore is touched also by your patch.

Another recent bug report pointed out that using :encoding(utf8) is preffered
above :utf8. The latter form is a lazy one in Perl. 

I saw that you decode output from the Zoom connection in Search.pm. Without
further investigation I am inclined to think that this is not (always) correct.
Apparently, you assume that the output from Zoom is utf8 octets. Isn't it Latin
and doesn't Zoom allow you to pass a charset parameter like charset=latin,utf8
in order to change encoding? Could you verify?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.