[Koha-bugs] [Bug 6893] Order from suggestion does not remove suggestion from 'accepted' list

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Nov 4 15:03:42 CET 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6893

--- Comment #9 from Adrien SAURAT <adrien.saurat at biblibre.com> 2011-11-04 14:03:42 UTC ---
Two changes :
1) acqui/addorder.pl
line 215, if we have to change status we call ModSuggestion.
But the field name was called in lower-case, and expected later as upper-case.
Thus the 'ORDERED' state, for suggestions being ordered, was never attained.

This was the main problem. The suggestions remained in the ACCEPTED state, thus
being still displayed in the suggestions list, and probably causing problems
later with the e-mail sending (didn't test this part but this should rely on
the ORDERED state).


2) C4/Suggestions.pm
found there a SQL clause "WHERE STATUS NOT IN ('CLAIMED')"
but except here, CLAIMED was nowhere to be found in the code.
Seems logical to think that it was supposed to be NOT IN ('ORDERED').

===

For this bug, the 1st modification was enough to repair, as the suggestions
list called in newordersuggestion.pl already asks for the 'ACCEPTED' status (so
it's not necessary to exclude the ORDERED).
But the 2nd modification could (should) help in other parts. Were the
suggestions in OPAC correctly displayed ? Are the ordered suggestions supposed
to appear there ?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list