[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |paul.poulain at biblibre.com
         AssignedTo|gmcharlt at gmail.com          |chris at bigballofwax.co.nz

--- Comment #23 from Paul Poulain <paul.poulain at biblibre.com> 2011-11-06 17:04:15 UTC ---
The 2nd patch does not work well I think (it also does not apply, but it's
easily fixed)

in showmarc.pl, before your patch, my biblio with diacritic look like :
200 1  _aMassacre (The) éô ï
(éô ï is what i'm expecting)
After the patch, it looks like :
200 1  _aMassacre (The) éô ï
which is the sign of a double encoded biblio record.

Marking "failed QA" for now. The 3rd patch, that updates perlcritic.tt does not
apply after that (i've not tested further, I suspect they will conflict because
catalogue has not been added

Once the showmarc issue is solved, i'll test & push those usefull code cleaning
patches as fast as possible

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.