[Koha-bugs] [Bug 1633] Add ability to take book cover images from local img db

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 8 12:59:57 CET 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no
       Patch Status|Needs Signoff               |Failed QA

--- Comment #4 from Magnus Enger <magnus at enger.priv.no> 2011-11-08 11:59:57 UTC ---
* Patch did not apply, giving this message: "fatal: cannot convert from
UTF-8utf-8 to UTF-8". 
Removing 'Content-Type: text/plain; charset="utf-8"' from the patch by hand
solved this. 

* There are a couple of typos in updatedatabase.pl: 
- "Display local cover mages on OPAC"
- "table to stover local cover images"

* Comment #3 says "Images should be 140x200 pixels. If they are larger they
will be auto-resized to comply", but the code in upload-cover-image.pl seems to
implement a max size of 200x300 (which is way too big if you ask me): 

$debug and warn "$filename is $width pix X $height pix.";
if ($width > 200 || $height > 300) {    # MAX pixel dims are 200 X 300...
$debug and warn "$filename exceeds the maximum pixel dimensions of 200 X 300.
Resizing...";

* A couple of things in the templates:

- opac-detail.tt: Why have alt="No Local Cover Image" when the image is
actually displayed? 
[% IF ( OPACLocalCoverImages ) %] <img
src="/cgi-bin/koha/opac-coverimage.pl?bibnum=[% biblionumber %]" alt="No Local
Cover Image" class="thumbnail" />[% ELSE %]<span class="no-image">No Local
cover image available</span>[% END %]

- opac-results.tt: Same problem with the alt text. And there is a missing "
after [% SEARCH_RESULT.biblionumber %]. 
[% IF ( OPACLocalCoverImages ) %] <img
src="/cgi-bin/koha/opac-coverimage.pl?bibnum=[% SEARCH_RESULT.biblionumber %]
alt="No Local Cover Image" class="thumbnail" />[% ELSE %]<span
class="no-image">No Local cover image available</span>[% END %]

* Questions/suggestion for enhancement
- The note that says "NOTE: Only PNG, GIF, JPEG, XPM formats are supported."
when you are about to upload an image could perhaps also mention the
restrictions on file size and dimensions?
- It looks like images on the result list and detail view will be the same
size? It would be nice to have small images in the result list and bigger
images on the detail view. 
- Maybe the max size could be configurable through systempreferences? 

This will be a great feature, though!

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the Koha-bugs mailing list