[Koha-bugs] [Bug 6916] Selecting the acq date of an item should take you to the invoice page for it

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6916

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Signed Off                  |Passed QA

--- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2011-11-16 13:13:31 UTC ---
Found it! Actually, this patch hits an existing bug in moredetail.pl, depending
on the value of pref AcqCreateItem.
If this pref is set to placing an order, it works because there are records in
aqorders_items. If it is set to receiving an order or cataloging the record, it
does not work since there are no records in aqorders_items.

Problem is in:
    my $order  = GetOrderFromItemnumber( $item->{'itemnumber'} );
    my $basket = GetBasket( $order->{'basketno'} );
    $item->{'booksellerid'}            = $basket->{'booksellerid'};
    $item->{'ordernumber'}             = $order->{'ordernumber'};
    $item->{'basketno'}                = $order->{'basketno'};
    $item->{'booksellerinvoicenumber'} = $order->{'booksellerinvoicenumber'};
    $item->{'datereceived'}            = $order->{'datereceived'};

Depending on AcqCreateItem $order is filled or not. If not, $basket is empty
too, the remaining lines are useless.
Although this report was not opened to resolve this bug initially, I hope Robin
can send a follow up to fix this issue too. Note that the order number could be
found too via biblionumber. So, it could be fixed in GetOrderFromItemnumber.
Hoping that and realizing that this patch did not introduce the bug, I am
setting status to Passed QA.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.