[Koha-bugs] [Bug 7113] Standardize vendor id name in templates and scripts

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6114|0                           |1
        is obsolete|                            |
   Attachment #6189|0                           |1
        is obsolete|                            |
   Attachment #6369|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> 2011-11-27 17:13:27 UTC ---
Created attachment 6437
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6437
[SIGNED-OFF] Fix for Bug 7113 - Standardize vendor id name in templates and
scripts

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Update: Fixed conflict in basket.tt

Signed off this patch, but before it can go into master a follow up is needed
to fix
the found issues marked as 'BROKEN' in the test plan.

This patch touches a lot of links in acquisitions. Tested:

Vendor result list (booksellers)
- link to vendor summary page
- link to receive shipment
- new basket

Vendor summary (supplier)
- links to contract summary
- BROKEN: Edit vendor: redirect after saving
- edit vendor > cancel
- BROKEN: redirect after saving/editing/adding contract
- contracts list from toolbar
- new basket

Basketgroups (basketgroup)
- breadcrumbs: link to vendor
- link back to vendor summary
- edit basketgroup > save
- delete basketgroup
- link to vendor from toolbar
- (BROKEN) edit vendor from toolbar - does not open edit page
- uncertain prices

Uncertain prices (uncertainprice)
- breadcrumbs: link to vendor
- link to vendor summary
- link to edit vendor - here it works
- edit po line
- changing price and submitting

Basket header (basketheader)
- breadcrumbs: link back to vendor
- link for saving

New basket (basket)
- breadcrumbs: link back to vendor
- delete basket (redirects to search list, ok)
- export as csv
- close basket
- cancel order
- modify order

Order from existing record (neworderempty)
- breadcrumbs: link back to vendor
- order

Order from suggestion (newordersuggestion)
- breadcrumbs: link back to vendor
- order
- cancel

Order from external source (z3950_search)
- breadcrumbs: link to vendor
- order
- after ordering: neworderenry > edit record

Order new (neworderentry)
- breadcrumbs: link to vendor
- save
- cancel

Receive shiptment (parcels)
- breadcrumbs: link to vendor
- cancel

Order receive (parcel)
- Finish receiving
- Cancel receiving
- link to order line
- receive
- BROKEN: delete order redirects to wrong page
- BROKEN: delete order and catalog record redirects to wrong page

Late orders (lateorders)
- filter on specific vendor

Follow-up fixes for Bug 7113, Standardize vendor id name in templates and
scripts

Fixed:

- Edit vendor: redirect after saving
- redirect after saving/editing/adding contract
- edit vendor from toolbar - does not open edit page

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
1) redirect after editing vendor is ok
2) saving and deleting contract is perfect, one little improvement:
The cancel link takes you back to the list of contracts, not to the vendor
detail page.
I think it would be a little better if save and cancel redirected to the same
page.
3) editing vendor from basket group toolbar works now

[SIGNED-OFF] Bug 7113 Fix for a missed instance of the wrong variable name

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Link back to vendor in breadcrumbs of contract page works now too.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.