[Koha-bugs] [Bug 7272] Fix for Bug 6328 causes user accounts to be frozen

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7272

--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> 2011-11-30 13:30:58 UTC ---
(In reply to comment #5)
> Paul,
you've beaten me by 20 seconds ;-)

> ...but it may be a better idea to actually fix the SIP code at the point Larry
> indicated to cope with the fact that borrowers.debarred is no longer a boolean.
>  Similar gotchas may exist elsewhere in Koha.  To do this with minimal code
> touching you could set $debarred based on the value (at
> C4/SIP/ILS/Patron.pm:51)--if borrowers.debarred is NULL or "0000-00-00" or a
> date IN THE PAST, set zero, otherwise, set 1.  Then the rest of the SIP checks
> for $debarred would work correctly.

I'm not sure = 0000-00-00 is a date that should never be here. You can't assign
such a date manually, and it is never assigned by Koha itself (otherwise, it's
a bug ;-) ). So setting NULL during updatedatabase is OK I think.
your opinion ? (available on IRC if usefull)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.