[Koha-bugs] [Bug 6576] changing framework while cataloging looses data

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 5 17:16:23 CEST 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6576

--- Comment #7 from Ian Walls <ian.walls at bywatersolutions.com> 2011-10-05 15:16:23 UTC ---
Srdjan,


The addition of this logic to addbiblio.pl is causing bug 6974:

+    if ( $record eq -1 ) {
+        $record = TransformHtmlToMarc( $input );
+    }
+    else {
 #FIXME: it's kind of silly to go from MARC::Record to MARC::File::XML and then
back again just to fix the encoding
-    eval {
-        my $uxml = $record->as_xml;
-        MARC::Record::default_record_format("UNIMARC")
-          if ( C4::Context->preference("marcflavour") eq "UNIMARC" );
-        my $urecord = MARC::Record::new_from_xml( $uxml, 'UTF-8' );
-        $record = $urecord;
-    };
+        eval {
+            my $uxml = $record->as_xml;
+            MARC::Record::default_record_format("UNIMARC")
+            if ( C4::Context->preference("marcflavour") eq "UNIMARC" );
+            my $urecord = MARC::Record::new_from_xml( $uxml, 'UTF-8' );
+            $record = $urecord;
+        };
+    }

Can you help me understand the reasoning behind adding the conditional check
for $record eq -1?  What does that fix?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


More information about the Koha-bugs mailing list