[Koha-bugs] [Bug 7002] New: Inaccurate checks for borrower flags == 1

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002

             Bug #: 7002
           Summary: Inaccurate checks for borrower flags == 1
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Authentication
        AssignedTo: gmcharlt at gmail.com
        ReportedBy: oleonard at myacpl.org
         QAContact: koha-bugs at lists.koha-community.org
                CC: dpavlin at rot13.org


There are a few instances in the code which I can find which use this to check
whether someone has superlibrarian privileges in the context of
IndependandBranches:

unless (($userenv->{'flags'} == 1) or ($userenv->{'branch'} eq
$item->{'homebranch'})) {

This check fails if the logged in user has any other privilege checked in
addition to superlibrarian. In other words, the user must *only* have
superlibrarian checked in order to qualify to perform these operations.

catalogue\moredetail.pl line 136
cataloguing\additem.pl line 548
tools\batchMod.pl line 460

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.