[Koha-bugs] [Bug 6885] Superlibrarian users can't delete items from another library when IndependantBranches

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6885

--- Comment #9 from Frédéric Demians <frederic at tamil.fr> 2011-10-12 15:55:18 UTC ---
(In reply to comment #8)
> This will work to add the permissions check, yes, and it is consistent
> with how superlibrarian is tested in other parts of the code.  This
> method (modulo 2) is not universal, however, and another bug report
> should be filed to apply a uniform checking methodology across the
> entire codebase.  I recommend bitwise AND.

Yes, you're correct, and there are a lot of locations in Koha where
permissions flags are not properly tested. A 'grep -R flags' show them.
The superlibrarian permission should be tested like this:

  if $flags & 1 

cataloguing: $flags & 4

and so on...

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.