[Koha-bugs] [Bug 6253] Unified Patron Search subroutine

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6253

--- Comment #26 from Srdjan Jankovic <srdjan at catalyst.net.nz> 2011-10-13 02:49:26 UTC ---
SQLHelper::SearchInTable() is not the best tool for creating queries, but it is
much better than having nothing. Member search can get quite complex, so I had
to address some deficiencies in order to be able to build it. Other parts of
the system are using SearchInTable() in its simplest form, so they are not
affected:
* SearchInTable() used in Budgets:
- admin/aqbudgetperiods.pl calls GetBudgetPeriods() without any params, ie
SearchInTable() is used to return a full table scan
- suggestion/suggestion.pl calls GetBudgetPeriods() with simple filter
budget_branchcode => $code, so no ANDing nor ORing; all other calls are without
any params
* SearchInTable() used in Contracts:
- admin/aqcontract.pl calls GetContract() with simple filter contractnumber =>
$contractnumber, or booksellerid => $booksellerid
- acqui/supplier.pl calls GetContract() with simple filter booksellerid =>
$booksellerid

It is not up the query builder to consider indexing. Although some useful
tweaks can be done (eg if value list is supplied that translates to field_x IN
(val1, val2, ...) it is a good optimisation to write it as field_x = val1 if
there's only one value), in general query builder should make an accurate
query, and indexing should be considered outside.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.