[Koha-bugs] [Bug 6253] Unified Patron Search subroutine

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6253

--- Comment #27 from Paul Poulain <paul.poulain at biblibre.com> 2011-10-14 08:13:25 UTC ---
(In reply to comment #26)
> Other parts of
> the system are using SearchInTable() in its simplest form, so they are not
> affected:
OK, I confirm, other parts of the system are not affected.

> It is not up the query builder to consider indexing. Although some useful
> tweaks can be done (eg if value list is supplied that translates to field_x IN
> (val1, val2, ...) it is a good optimisation to write it as field_x = val1 if
> there's only one value), in general query builder should make an accurate
> query, and indexing should be considered outside.
I was not only a question of indexes, it also a question of which query we want
to do. A and B won't return the same result as A or B (in french we say :
"trying to push open-door", I agree ;-) )
So this change is not a small one. But as only your query uses it, it's OK.

So I vote for "passed QA", and pass the ball to Ian and/or chris : this update
is not minor, please check my opinion & accept or object.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.