[Koha-bugs] [Bug 5549] Hourly Loans

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5549

Ian Walls <ian.walls at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Pushed For QA               |Failed QA

--- Comment #26 from Ian Walls <ian.walls at bywatersolutions.com> 2011-10-17 18:14:50 UTC ---
Notes from testing Elliott's merge work:


Unit Type is free text; should be dropdown.  Empty values can be supplied, as
well as nonsense values like "widgets".  We need to tighten this up for
usability, as well as be sure to provide explicit default value of 'Days' in
case the form is submitted without a value unittype param.

References to 'decreaseLoanHighHoldsDuration' and 'decreaseLoanHighHoldsValue'.
 This is happening in the checkHighHolds() subroutine (incorrectly documented
as CheckHighHolds in POD).  Looks like this is an additional feature that will
shorten an item's loan period based on whether it has many holds.  An
interesting and valuable feature to be sure, but not part of of Hourly Loans. 
I also fail to see the preference in the Syspref Editor.

Seems to also include the changes for bug 6321, which has not yet passed QA.

Also includes 3.4.1 release notes, which are not appropriate for this base, as
well as a ton of .po files.

Other included work seems to include SIP2 Authentication changes (adding
institution code to login)

Use of CURDATE() in SQL circulation functions almost entirely eradicated in
favour of NOW(), except in longoverdue.pl.


Given the usability issue in the circ rules, as well as the several other bug
fixes/enhancements which seem to be mixed in, I'm marking this as Failed QA for
now.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.