[Koha-bugs] [Bug 5179] GetMember and GetMemberDetails should be combined

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5179

Ian Walls <ian.walls at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |ian.walls at bywatersolutions.
                   |                            |com
         Resolution|                            |WONTFIX

--- Comment #1 from Ian Walls <ian.walls at bywatersolutions.com> 2011-10-18 22:20:17 UTC ---
GetMember is VASTLY more efficient that GetMemberDetails.  For almost all
purposes, GetMember is sufficient.  For those rare occasions when you need more
than what's in the borrower table, then use GetMemberDetails.  But outside of
the patron details pages, that should not be necessary.

GetMemberDetails calls GetMemberAccountRecords and patronflags.

GetMemberAccountRecords calls GetBiblioFromItemNumber for EVERY accountlines
entry that has a borrowernumber.

patronflags calls GetMemberAccountRecords (!), checkoverdues, and
GetReservesFromBorrowernumber.

checkoverdues does a join across biblio, biblioitems, items and issues

GetReservesFromBorrowernumber is relatively benign.


In any situation where more than a single borrowernumber per pageload is
provided to GetMemberDetails, this gets to be a huge waste of resources. 
Either we need to completely rebuild these subroutines to be more efficient, or
make sure GetMemberDetails is only used when absolutely necessary.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.