[Koha-bugs] [Bug 7060] New: All instances of GetMemberDetails are unnecessary in C4::Circulation

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7060

             Bug #: 7060
           Summary: All instances of GetMemberDetails are unnecessary in
                    C4::Circulation
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Architecture, internals, and plumbing
        AssignedTo: ian.walls at bywatersolutions.com
        ReportedBy: ian.walls at bywatersolutions.com
         QAContact: koha-bugs at lists.koha-community.org
            Blocks: 7058


GetMemberDetails is used in the following C4::Circulation subroutines

CanBookBeIssued:  used twice, both times only cardnumber, surname, firstname,
and borrowernumber are used, which are all accessible more efficiently from
GetMember

AddReturn:  only borrowernumber and cardnumber are used.  the $borrower hashref
is returned by AddReturn, but it is only captured in tools/inventory.pl and
C4/SIP/ILS/Transaction/Checkin.pm, and in neither place is anything done with
it.  GetMember could be used here without any issue

AddRenewal: uses only passes the $borrower object to CalcDateDue, which only
uses categorycode and dateexpiry (both covered by GetMember hashref)

AddIssue:  uses an incoming $borrower object, but only the borrowernumber and
categorycode fields, so we only need a GetMember object here.

GetRenewalCount:  only uses categorycode

Changing all calls of GetMemberDetails to GetMember in C4/Circulation.pm should
be safe, and vastly more efficient

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.