[Koha-bugs] [Bug 7061] New: SQLHelper has unused global variables

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 19 02:16:44 CEST 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061

             Bug #: 7061
           Summary: SQLHelper has unused global variables
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Architecture, internals, and plumbing
        AssignedTo: ian.walls at bywatersolutions.com
        ReportedBy: ian.walls at bywatersolutions.com
         QAContact: koha-bugs at lists.koha-community.org


my $tablename and my $hash are globally defined in C4::SQLHelper, but are never
used; all subroutines use a locally scoped $tablename, and $hash is never used,
locally or otherwise.

Removing these two lines may help ensure mod_perl compatibility (since
variables in subroutines cannot safely alter values in outer script in
persistent environments).  Or not.  If nothing else, it's just a bit a trivial
cleanup.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


More information about the Koha-bugs mailing list