[Koha-bugs] [Bug 7061] SQLHelper has unused global variables

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 19 21:56:14 CEST 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7061

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5970|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> 2011-10-19 19:56:14 UTC ---
Created attachment 5997
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5997
[SIGNED-OFF] Bug 7061: unnecessary global variables declared in C4::SQLHelper

Removes $tablename and $hash from global scope of C4/SQLHelper.pm.  They are
never used;
all instances of $table are locally scoped to the subroutines, and $hash is
never used.

This may help with persistance; if not, it's at least a bit of trivial cleanup.

To test:

1.  Search for a patron
2.  Create a Contract in Acquisitions
3.  Modify that Contract
4.  Delete that Contract

All instances should return error free.  This checks the subroutines of
SQLHelper

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


More information about the Koha-bugs mailing list