[Koha-bugs] [Bug 7075] New: Fine in days values are returned for patrons with past overdues when fine in days is set to 0

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075

             Bug #: 7075
           Summary: Fine in days values are returned for patrons with past
                    overdues when fine in days is set to 0
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: critical
          Priority: P5
         Component: Circulation
        AssignedTo: kyle.m.hall at gmail.com
        ReportedBy: oleonard at myacpl.org
         QAContact: koha-bugs at lists.koha-community.org
                CC: gmcharlt at gmail.com


When Members.pm checks to see whether a particular patron can check out, it
checks for issuingrules.finedays "WHERE finedays IS NOT NULL." If the user has
created a rule via Circulation and fines rules, finedays will always be 0 even
if an empty value has been submitted. This causes Members::IsMemberBlocked to
return a value when it should not.

[09:57]    <sekjal>    IsMemberBlocked checks for finedays IS NOT NULL
[09:58]    <oleonard>    ...and it's 0.
[09:58]    <sekjal>    so, if you have finedays = 0 in any of your rules, it'll 
                        trigger
[09:59]    <sekjal>    so, in that case, it'll just take the date difference 
                        between the returndate, and the current date
[09:59]    <sekjal>    which means it would grow to 44 tomorrow
[09:59]    <sekjal>    and so on
[09:59]    <sekjal>    that's.... bad
[09:59]    <libsysguy>    ^^
[09:59]    <oleonard>    And you can't set finedays to null when editing an 
                        issuing rule
[10:00]    <libsysguy>    so we could change that check or null or 0
[10:00]    <libsysguy>    and it would fix your issue right
[10:00]    <sekjal>    yes, that's the fix
[10:00]    <sekjal>    one more line to the SQL
[10:00]    <sekjal>    "AND finedays != 0"

http://stats.workbuffer.org/irclog/koha/2011-10-21#i_795577

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.