[Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6094|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> 2011-10-28 19:42:22 UTC ---
Created attachment 6103
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6103
Bug 7110 - Renewal messages still display in OPAC if OpacRenewalAllowed is
disabled

This patch adds a check for OpacRenewalAllowed to the computation of the
renewal_blocked_fines. If OpacRenewalAllowed is off, renewal_blocked_fines
won't be computed, because that message shouldn't show in the OPAC anyway.
This also removes the necessity to set a very high threshold on
OPACFineNoRenewals to prevent the messages from showing with OpacRenewal
disabled.

To test:
Set a patron with fines over the stated limit in OPACFineNoRenewals.

With OpacRenewalAllowed set to ALLOW
- log into the OPAC and verify the message that renewals are disallowed is
displayed
- verify that renewals are disallowed in the interface.
- remove or pay the fines, verify the message goes away and that OPAC renewals
are re-allowed for your patron.

With OPACFineNoRenewals set to Don't Allow
- verify the message is not shown, even with the patron's fines over the
threshold in OPACFineNoRenewals.
- remove or pay the fines, verify that renewals are still disallowed

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.