[Koha-bugs] [Bug 5630] CAS improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Needs Signoff               |Failed QA

--- Comment #28 from Chris Cormack <chris at bigballofwax.co.nz> 2011-09-02 01:22:41 UTC ---
Sorry my bad, I shouldn't have pushed this.

It contains code that changes more than just CAS, including code that changes
the way search history is stored, and without a corresponding change to the
database. 

I am reverting it, it needs to be tidied up, the changes like

+VALUES                    (     ?,         ?,          ?,         ?,         
?,         ?,     ?, FROM_UNIXTIME(?))
 EOQ
 sub get_template_and_user {
     my $in       = shift;
@@ -264,13 +271,9 @@ sub get_template_and_user {
                     my @recentSearches = @{thaw($searchcookie) || []};
                 if (@recentSearches) {
                     my $sth = $dbh->prepare($SEARCH_HISTORY_INSERT_SQL);
-                    $sth->execute( $borrowernumber,
-                               $in->{'query'}->cookie("CGISESSID"),
-                               $_->{'query_desc'},
-                               $_->{'query_cgi'},
-                               $_->{'total'},
-                               $_->{'time'},
-                                        ) foreach @recentSearches;
+                    
+                    $sth->execute( $borrowernumber,
$in->{'query'}->cookie("CGISESSID"), $_->{'query_desc'}, $_->{'query_cgi'},
$_->{'limit_desc'}, $_->{'limit_cgi'}, $_->{'total'}, $_->{'time'}, )
+                                foreach @recentSearches;

Need to be removed and put in their own bug. With the corresponding database
change, the lack of which is causing the error Marcel reports
Plus the patch from Ian integrated.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.