[Koha-bugs] [Bug 5724] Sometimes deletes aren't processed correctly by rebuild zebra

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5724

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Needs Signoff               |Failed QA

--- Comment #24 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2011-09-02 12:16:50 UTC ---
My comments FWIW:

I cannot reproduce this bug by deleting records and updating zebra. (Note that
there is no test plan.) I can imagine that deleting a record while zebra is
updating occasionally could result in a corrupted index. Harder to test.
But I still have my doubts if this code really works. Some comments about it:

1) [MAIN point] The order of updating and deleting is changed. But does it
really make a difference? Routine export_marc_records_from_list already filters
out deleted records with:
foreach my $record_number ( map { $_->{biblio_auth_number} }
                                grep { !$found{ $_->{biblio_auth_number} }++ }
                                @$entries ) {
[side note: the increment (++) after $found has no effect; the value is already
1 or undef]
So the update file does not contain deleted recs already (without this patch)!
Changing the order is fine, but appears to have no effect. The two files
(delete and update) are mutually exclusive on record numbers.

2) In routine get_raw_marc_record:
statement eval { $marc = GetMarcBiblio($record_number,"include_deleted_table");
} suggests something like including deleted records but the second parameter is
actually asking for embedded items (see Biblio.pm)

3) generate_deleted_marc_records calls fix_biblio_ids with two record numbers,
so it will never hit the deleted table
it does only hit the deletedbiblioitems from get_corrected_marc_record (called
from export_marc_records_from_list)

4) Small whitespace error:
../5724.patch:42: trailing whitespace.
        do_indexing($record_type, 'delete', "$directory/del_$record_type",
$reset, $noshadow, $record_fmt, $zebraidx_log_opt)
warning: 1 line adds whitespace errors.

Changing status.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.