[Koha-bugs] [Bug 4530] Circulation & fines rules aren't always applied from most specific to less specific

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gmcharlt at gmail.com          |srdjan at catalyst.net.nz

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> 2011-09-07 02:26:02 UTC ---
Created attachment 5329
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5329
patch

I've made a single-entry point for issuing rules. That is good.
The bad ting is that the current implementation does not store nulls for
numeric values, but 0. In those cases we have no way of knowing if 0 *is* the
value, or we should fall back to the next more generic rule.

What I have done is:
* 0 is treated as null, ie no rule
* when selecting rules order of preference is: borrower category, item type,
branch

All relevant parts of the system need to be tested. I tried Holds, Check Out
and Renewals myself.

If that is of any help, affected functions are:
CanItemBeReserved
CanBookBeIssued
GetIssuingCharges
AddIssue
GetRenewCount
CanBookBeRenewed
AddRenewal
CalcFine

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.