[Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Sep 12 15:47:48 CEST 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com
       Patch Status|Needs Signoff               |Failed QA

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> 2011-09-12 13:47:48 UTC ---
QA comment(s)
Before testing this patch, some QA comments :

+    remoteipcheck        => C4::Context->preference("remoteipcheck"),

seems useless to me = there's no need to send this syspref to the templates
(and you don't doo anything with it anyway)

Also note that this patch won't apply anymore due to the changes in the syspref
system that has been pushed recently (see bug 6537)

Also note that we have suggested/proposed that updatedatabase are provided in a
separate patch, so as you take care of the previous suggestion, can you do this
as well ?


Could you submit an enhanced patch please, and reset to "need signoff", I set
"failed QA"

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


More information about the Koha-bugs mailing list