[Koha-bugs] [Bug 6673] Create Batch Label from Staged MARC Records fails after upgrade to 3.4.x

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6673

--- Comment #8 from Ian Walls <ian.walls at bywatersolutions.com> 2011-09-21 02:29:25 UTC ---
Further evidence:  all other invocations of the variable LoginBranchname work
like this:

get_branch_code_from_name($template->{VARS}->{'LoginBranchname'})

Whereas (at least before the attached patch), manage-marc-import.pl does this:

get_branch_code_from_name($template->param('LoginBranchname'))

By default, LoginBranchname is defined as:

C4::Context->userenv?C4::Context->userenv->{"branchname"}:"insecure"
or
C4::Context->userenv?C4::Context->userenv->{"branchname"}:""

depending on what part of C4/Auth.pm you look at.

Since 'insecure' and '' are both invalid entries, it makes more sense to bypass
the code=>name=>code jump, and just invoke the code in the standard fashion, as
submitted in this patch.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.