[Koha-bugs] [Bug 6801] Patron details page slow to load when many checkouts present

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6801

--- Comment #6 from Liz Rea <wizzyrea at gmail.com> 2011-09-22 15:37:16 UTC ---
Created attachment 5544
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5544
Bug 6801: checkoverdues returns unnecessary fields, causing slowness

Explicitly specifies which fields to return in C4::Overdues::checkoverdues
SQL:  all of biblio, items, and issues, and everything in biblioitems
EXCEPT marc, marcxml and timestamp.

Bug 6801: member details page taking long time to load when many checkouts
present

This patch removes the call to GetMemberDetails in build_issue_data; this
heavy-weight
subroutine was being run for every single item a patron (or their relatives)
have checked out.
Instead, the borrowers first name, surname and cardnumber are added to the
GetPendingIssues query.
I believe this is reasonable since GetPendingIssues can now return issues for
multiple borrowers.

Also corrects the $borrowernumber used for GetIssuesCharges and
CanItemBeRenewed; was using the borrower whose
page we were on, NOT the borrower of that specific item (which would be
different in the Relatives Checkouts tab).

Template calls to [% scope.borrowername %] are now broken up into [%
scope.firstname %] [% scope.surname %].

Signed-off-by: Liz Rea <lrea at nekls.org>
On my test data, a patron with 180 checkouts (without this patch) would take
more than a minute to bring back the circulation.pl and moremember.pl pages.
With this patch, the time is reduced to 5 or so seconds.

Big ups to Ian for tenaciously hunting this one down.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.