[Koha-bugs] [Bug 5806] Search results display items for all locations when the SearchMyLibrary first system pref is activated

Tue Sep 27 18:43:44 CEST 2011

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5806

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Needs Signoff               |Failed QA

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> 2011-09-27 16:43:44 UTC ---
I don't have tested the patch, but I mark is "failed QA" because it seems there
are many things that are not related to the goal of the patch.

Just 3 examples :

    ModBiblioframework($biblionumber,$frameworkcode);
@@ -2730,7 +2732,10 @@ sub EmbedItemsInMarcBiblio {
         my $item_marc = C4::Items::GetMarcItem($biblionumber, $itemnumber);
         push @item_fields, $item_marc->field($itemtag);
     }
-    $marc->insert_fields_ordered(@item_fields);
+        if (defined $marc)
+        {
+             $marc->insert_fields_ordered(@item_fields);
+        }   
 }

and 
 sub z3950_search_args {
     my $bibrec = shift;
-    $bibrec = { title => $bibrec } if !ref $bibrec;
+  
+ 
+    if (validate_isbn($bibrec) == 1)
+    {
+    $bibrec = { isbn => $bibrec } if !ref $bibrec;
+}
+else {
+     $bibrec = { title => $bibrec } if !ref $bibrec;
+}

and a new index.htm file:

diff --git a/index.htm b/index.htm
new file mode 100755
index 0000000..30a4b1e
--- /dev/null
+++ b/index.htm
@@ -0,0 +1,131 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
+  <head>
+    <title>Scooter Online Library System</title>
+ 
+    <meta name="MSSmartTagsPreventParsing" content="true" />
+    <link id="theme" rel="stylesheet" type="text/css" href="style.css"
title="theme" />
+<script type="text/javascript" language="javascript"
src="js/addon.js"></script>
+<script type="text/javascript" language="javascript"
src="js/custom.js"></script>
+  </head>
+  <body bgcolor="#E0E0E"> 
+    <!-- top wrapper -->  
+   
+      <div id="topSlideshowWrapper"> 
+        <div id="sliderContainer">

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
