[Koha-bugs] [Bug 6931] New: hardcoded insert incompatible with UNIMARC

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6931

             Bug #: 6931
           Summary: hardcoded insert incompatible with UNIMARC
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: rel_3_6
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: blocker
          Priority: P5
         Component: Database
        AssignedTo: gmcharlt at gmail.com
        ReportedBy: paul.poulain at biblibre.com
         QAContact: koha-bugs at lists.koha-community.org


In updatedatabase, the $DBversion = "3.03.00.015";
contains :
    my $sth = $dbh->prepare("INSERT INTO `marc_subfield_structure` (`tagfield`,
`tagsubfield`, `liblibrarian`, `libopac`, `repeatable`, `mandatory`,
`kohafield`, 
                             `tab`, `authorised_value`, `authtypecode`,
`value_builder`, `isurl`, `hidden`, `frameworkcode`, `seealso`, `link`,
`defaultvalue`)
                             VALUES ( ?, '9', '9 (RLIN)', '9 (RLIN)', 0, 0, '',
6, '', '', '', 0, -5, '', '', '', NULL)");
    $sth->execute('648');
    $sth->execute('654');
    $sth->execute('655');
    $sth->execute('656');
    $sth->execute('657');
    $sth->execute('658');
    $sth->execute('662');


=>> it's marcflavour independant and will result in some pain in UNIMARC !
(648...662 should not exist in standard UNIMARC so, 1- dead data will be added
and 2-if a library uses those fields for local use, that will break a lot of
things (ie : the 6xx are used for authorities, the $9 for authid, so, I don't
imagine what the result will be !)

A simple if syspref("marcflavour") eq "marc21" before the insert should fix the
bug

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.