[Koha-bugs] [Bug 7874] New: Templates::get_language generates lots of not defined warnings

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7874

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 7874
          Assignee: gmcharlt at gmail.com
           Summary: Templates::get_language generates lots of not defined
                    warnings
        QA Contact: koha.sekjal at gmail.com
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: colin.campbell at ptfs-europe.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Architecture, internals, and plumbing
           Product: Koha

Was trying to track another error and found the get_languages routine in
C4::Templates was giving lots of not defined errors in the logs. Looking closer
found that the routine has obviously grown by accretion and was a) not always
too clear in its intention b) was carelessly using undefined values c) was
actually passing undef to other routines so they could in turn log warnings and
return undef - only a few cycles wasted but it is a routine that could be
called freqently. 
Have refactored the routine to address these concerns

-- 
You are receiving this mail because:
You are watching all bug changes.