[Koha-bugs] [Bug 7291] claims management improvement

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7291

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #17 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Additional QA comment:

I have no real objections for pushing this patch, but want to note:

1) Use of adddate, date_sub, ifnull: they are all mysql-isms
I suspect that you could not avoid them here; and they are already present too.
But what is the use of replacing curdate's and backquotes if we do not remove
typical mysql date/time functions? But this is a discussion on itself, and
should be held elsewhere. 

2) BTW You add backtics in kohastructure with this patch (instead of removing
them..)

3) Very small note: You edited the part with the cryptic test: not $delay =~
/^\d{1,3}$/
Actually, we do not want a delay>999 (for some reason). If you edit that line,
please make the test faster and more readable with delay>999.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.