[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 10 13:46:20 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8951|0                           |1
        is obsolete|                            |

--- Comment #61 from Paul Poulain <paul.poulain at biblibre.com> ---
Comment on attachment 8951
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8951
Bug 6679 : [SIGNED-OFF] Fixing some perlcritic violations in the opac

This patch has been pushed

A few scripts still not perlcritic compliant in opac/ directory:
opac/changelanguage.pl: Code before strictures are enabled at line 24, column
1.  See page 429 of PBP.  (Severity: 5)
opac/ilsdi.pl: Stricture disabled at line 217, column 17.  See page 429 of PBP.
 (Severity: 5)
opac/opac-detail.pl: Variable declared in conditional statement at line 139,
column 9.  Declare variables outside of the condition.  (Severity: 5)
opac/opac-detail.pl: Variable declared in conditional statement at line 140,
column 9.  Declare variables outside of the condition.  (Severity: 5)
opac/opac-detail.pl: Variable declared in conditional statement at line 416,
column 1.  Declare variables outside of the condition.  (Severity: 5)
opac/opac-reserve.pl: Subroutine prototypes used at line 51, column 1.  See
page 194 of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list