[Koha-bugs] [Bug 7849] Instant Fine Calculation at Checkin

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7849

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> ---
mmm... something goes wrong:

When I apply those patches:
* the 1st does not apply, there's a tiny conflict in use, that I think I can
fix easily
* the 2nd one apply smoothly, BUT,

circ/circulation-home.pl gives me a bad:

syntax error at /home/paul/koha.dev/koha-community/C4/Circulation.pm line 1620,
near ") ) "
Global symbol "$amount" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1624.
Global symbol "$type" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1624.
Global symbol "$borrowernumber" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1628.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1628.
Global symbol "$circControlBranch" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1628.
Global symbol "$borrower" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1628.
Global symbol "$messages" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1629.
syntax error at /home/paul/koha.dev/koha-community/C4/Circulation.pm line 1630,
near "}"
Global symbol "$issue" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1632.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1632.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1637.
Global symbol "$branch" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1637.
Global symbol "$branch" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1638.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1638.
Global symbol "$item" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1639.
Global symbol "$branch" requires explicit package name at
/home/paul/koha.dev/koha-community/C4/Circulation.pm line 1639.
syntax error at /home/paul/koha.dev/koha-community/C4/Circulation.pm line 1640,
near "}"
/home/paul/koha.dev/koha-community/C4/Circulation.pm has too many errors.
Compilation failed in require at
/home/paul/koha.dev/koha-community/C4/Overdues.pm line 26.
BEGIN failed--compilation aborted at
/home/paul/koha.dev/koha-community/C4/Overdues.pm line 26.
Compilation failed in require at
/home/paul/koha.dev/koha-community/C4/Members.pm line 30.
BEGIN failed--compilation aborted at
/home/paul/koha.dev/koha-community/C4/Members.pm line 30.

Looking at the patch, I don't understand what's happening :'(

You've submitted the patch with tabs, and i've set a git rule to transform them
to spaces. My supposition is that something went wrong with this.
Could you resubmit your patch with spaces instead of tab please ?
(switch back to passed QA once you've submitted)

-- 
You are receiving this mail because:
You are watching all bug changes.